Skip to content

fix(dolphin): preserve NOT EXISTS expressions - #4526

Closed
muratmirgun wants to merge 1 commit into
sqlc-dev:mainfrom
muratmirgun:claude/fix-mysql-not-exists-4512
Closed

fix(dolphin): preserve NOT EXISTS expressions#4526
muratmirgun wants to merge 1 commit into
sqlc-dev:mainfrom
muratmirgun:claude/fix-mysql-not-exists-4512

Conversation

@muratmirgun

Copy link
Copy Markdown

Fix MySQL AST conversion dropping NOT from NOT EXISTS expressions.

the affected syntax in two different ways:

  • NOT (EXISTS (...)) as a unary NOT operation
  • NOT EXISTS (...) through ExistsSubqueryExpr.Not

The Dolphin converter did not handle either representation correctly. In the parenthesized case, the entire WHERE expression could be dropped, including nested sqlc.arg parameters. In the direct case, the query was preserved but the NOT operator was lost.

This change:

@kyleconroy

Copy link
Copy Markdown
Collaborator

Can you please open an issue instead? I'm not accepting pull requests at the moment. Include the full schema and SQL queries that don't work.

@kyleconroy kyleconroy closed this Jul 30, 2026
@muratmirgun

Copy link
Copy Markdown
Author

Hello @kyleconroy reference issue here #4512

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants